Fixed Navigation Toolbar Visibility Issue on Dynamic Flyout Reset in FlyoutPage. #28209
+66
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @prakashKannanSf3972! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
PR Overview
This pull request addresses a bug where the navigation toolbar unexpectedly disappears on dynamic flyout resets in a FlyoutPage. The changes include adding a new unit test to verify toolbar visibility on flyout reset, and updating the NavigationPageToolbar logic to handle early returns when detecting a FlyoutPage as a parent.
Reviewed Changes
| File | Description |
|---|---|
| src/Controls/tests/Core.UnitTests/FlyoutPageUnitTests.cs | Added a new test method to verify that setting a new flyout page maintains the toolbar’s visibility across different flyout page depths. |
| src/Controls/src/Core/NavigationPage/NavigationPageToolbar.cs | Updated the OnPageAppearing method to include an early return if the current page is already part of a FlyoutPage, preventing redundant toolbar updates. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
4 tasks
|
/azp run |
jsuarezruiz
added
area-navigation
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
In a FlyoutPage, The Flyout section contains a ContentPage, and the Detail section is a ContentPage wrapped within a NavigationPage. The NavigationPage includes a TitleView. When the Flyout property is dynamically reset (e.g., Flyout = new ContentPage()), the navigation toolbar unexpectedly disappears in the FlyoutPage.
Root Cause
When the refreshed Flyout page is not a child of a NavigationPage, the toolbar visibility is set to false, resulting in its disappearance from the FlyoutPage.
Description Of Change
In a FlyoutPage, the Detail page handles navigation and determines the toolbar's visibility state. The change ensures that when the Flyout Page is CurrentPage, it returns early. When the Detail page is already managing the toolbar visibility, it prevents redundant updates and maintains the intended behavior.
Tested the behaviour in the following platforms
Issues Fixed
Fixes #21645
Output
BeforeFix.mov
AfterFix.mov
Before-Fix.mp4
After-Fix.mp4