Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for border color of the RadioButton is visible in Windows #28214

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix for border color of the RadioButton is visible in Windows #28214

wants to merge 4 commits into from
+41 −1

Conversation

SyedAbdulAzeemSF4852
Copy link

@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 commented Mar 6, 2025 •
edited
Loading

Issue Details

  • The border color of the radiobutton is visible only in windows.

Root Cause

  • If the stroke thickness is not explicitly set, a default Thickness object with a value of 3 is created, causing the border to be visible.

Description of Change

  • If the stroke thickness is not explicitly set, then created a default thickness object with a value of 0.

Validated the behaviour in the following platforms

  • Windows

  • Android

  • iOS

  • Mac

Issues Fixed

Fixes #28153

Output

Before Fix After Fix

Other Platforms Output

Android iOS Mac

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Mar 6, 2025
@SyedAbdulAzeemSF4852
Copy link
Author

@dotnet-policy-service agree company="Syncfusion, Inc."

@jsuarezruiz jsuarezruiz added the area-controls-radiobutton RadioButton, RadioButtonGroup label Mar 6, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz reviewed Mar 6, 2025
View reviewed changes
src/Controls/tests/TestCases.HostApp/Issues/Issue28153.cs
{
AutomationId = "RadioButton",
Content = "RadioButton",
BorderColor = Colors.Red
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include two radioButtons, one of them using the StrokeThickness property to validate all the scenarios with a single snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-controls-radiobutton RadioButton, RadioButtonGroup community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The border color of the RadioButton is visible in Windows only
2 participants
@SyedAbdulAzeemSF4852 @jsuarezruiz