add preview suffix in experimental CI Builds, enable expinsert #11534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanProvaznik
changed the title
JanProvaznik
changed the title
JanProvaznik
changed the title
JanProvaznik
changed the title
.vsts-dotnet.yml
Outdated
| foreach ($node in $nodes) { | ||
| $node.ParentNode.RemoveChild($node) | Out-Null | ||
| } | ||
| $xml.Save($versionsPath) |
There was a problem hiding this comment.
I don't love editing files on disk for this. Would it be possible to instead pass
/p:DotNetFinalVersionKind=prerelease /p:PreReleaseVersionLabel=experimental to the build command in this case?
There was a problem hiding this comment.
Ah actually it looks like that doesn't help like I thought. What about conditions in the project XML itself on a "This is experimental" property set in this yaml?
There was a problem hiding this comment.
Why wouldn't it help?
When I ran locally CIBuild.cmd /p:DotNetFinalVersionKind= it built the packages with suffixes which I wanted.
I'll delete the xml logic and test.
This logic comes from arcade
actually /p:SuppressFinalPackageVersion=true is even better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11492
Context
we added packages to feeds when developing whose version matched the ones we wanted to release, which lead to conflicts
Changes Made
Testing
MSBuild pipeline run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11123072&view=results
Exp Insertion: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11123201&view=results
Notes