[release/8.0-staging] Change assembler to clang in android MonoAOT #111666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
radical and
marek-safar
as code owners
This was referenced Jan 21, 2025
Open
…, libClang.so is no longer found in the place we expect. As a result, the android aot offsets won't be generated and the dedicated CI leg will fail. This change fixes the path.
jkurdek
force-pushed
the
backport/pr-110393-to-release/8.0-staging
branch
from
8c4219f to
64286d4
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 22, 2025
Open
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
jkurdek
requested review from
steveisok,
jeffschwMSFT,
ivanpovazan and
vitek-karas
and removed request for
SamMonoRT and
Copilot
jeffschwMSFT
approved these changes
Feb 13, 2025
jeffschwMSFT
added
the
Servicing-consider
ivanpovazan
approved these changes
Feb 17, 2025
rbhanda
added
Servicing-approved
|
@jkurdek please take a look at the PR failures. we can merge when ready |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g the failures are unrelated. Cryptography tests are a known failure |
3 tasks
|
/ba-g the failures are not on Android. unrelated. |
|
@jeffschwMSFT the failures are unrelated. I cant click the merge button for some reason. |
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110393 to release/8.0-staging
/cc @jkurdek
Customer Impact
The PR backports all the necessary bits for bumping the NDK version to 27. The currently used version (23) is significantly out of date and is not a supported version by Android. We have already bumped the version of the NDK used on .net10 and .net 9 branches.
Description of backported changes
This is the original change which made .net 10 build compatible with NDK 27.
The PR made MonoAOT compiler use clang assembler when building android.
net9 and net8 branches have a dependency on libclang.so for generating android aot offsets. (net10 [mono] Use libclang from dotnet/llvm-project for offsets-tool.py #109188). The library was taken from NDK as it used to ship with it. Since NDK 27 libclang.so is no longer a part of the NDK. The PR provides a path to local libclang.so to keep offset generation working
Change assembler to clang in android MonoAOT #110393 was based on this change. This was missing on net8 branch. This PR enables to choose which assembler and linker will be used for compilation on a given platform. (Without this change the choices are hardcoded per platform)
Fixes compilation warnings in System.Security.Cryptography.Native.Android which result from the NDK bump
Regression
Testing
https://github.com/dotnet/runtime/pull/112480/files
This PR references images with NDK 27. Failures on android lanes are unrelated to the changes in this PR.
Risk
Medium
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.