-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for packaging and other nits #40134
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @safern, @ViktorHofer |
Co-authored-by: Alexander Köplinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update docs for packaging and other nits
@@ -227,3 +221,17 @@ If you are working on Windows, and use Visual Studio, you can open individual li | |||
For more details about running tests inside Visual Studio, [go here](../../testing/visualstudio.md). | |||
|
|||
For more about running tests, read the [running tests](../../testing/libraries/testing.md) document. | |||
|
|||
## Build packages | |||
To build a library's package, simply invoke `dotnet pack` on the src project after you successfully built the .NETCoreApp vertical from root: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViktorHofer is there a ./build.sh
subset for building library packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmds yes there is. libs.packages -- however you would need to pass down an extra parameter.
./build.sh libs.packages -allConfigurations
. IIRC you will also need a prebuilt .NETCoreApp vertical from root.
Fixes #28244
That's the relevant section for how to build release packages now: https://github.com/dotnet/runtime/compare/master...ViktorHofer:DocsUpdates?expand=1#diff-79ae5ad83ec1d07a2c5628df6bb123e1R225.