Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NativeMemory.ZeroMemory #69948

Merged
merged 1 commit into from
May 29, 2022
Merged

Rename NativeMemory.ZeroMemory #69948

merged 1 commit into from
May 29, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 28, 2022

@jkotas
Rename NativeMemory.ZeroMemory
1e7ff1d 
- Rename NativeMemory.ZeroMemory to NativeMemory.Clear. Contributes to dotnet#69606
- Delete internal Buffer.ZeroMemory and replace it with NativeMemory.Clear
@jkotas jkotas requested a review from MichalStrehovsky as a code owner May 28, 2022 17:29
@ghost ghost assigned jkotas May 28, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 28, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: jkotas
Assignees: jkotas
Labels:

area-System.Memory, new-api-needs-documentation
Milestone: -

@jkotas
Copy link
Member Author

jkotas commented May 29, 2022

The test failure is #69474

@jkotas jkotas mentioned this pull request May 29, 2022
Closed
@jkotas jkotas merged commit 7aa4010 into dotnet:main May 29, 2022
@jkotas jkotas deleted the ZeroMemory branch May 29, 2022 01:52
@adamsitnik adamsitnik added this to the 7.0.0 milestone Jun 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@jkotas jkotas

Labels
area-System.Memory new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @stephentoub @adamsitnik