Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-staging: Enable failed tests on stable jobs to fail the job #73400

Merged
merged 4 commits into from
Aug 8, 2022
Merged

runtime-staging: Enable failed tests on stable jobs to fail the job #73400

merged 4 commits into from
Aug 8, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 4, 2022 •
edited
Loading

xplat-setup.yml: Add support for setting shouldContinueOnError to
.. false.

Currently, xplat-setup.yml passes on shouldContinueOnError to the
template with true if the parameter was true, else it sets the value
based on whether this is for runtime-staging, on a PR.

Which essentially means that runtime-staging defaults to
shouldContinueOnError: true for PRs, or we can set it explcitly to
true which would affect the rolling builds.

But this does not allow making a runtime-staging job fail when tests
fail. To support that this change adds a check for a special value
forceFalse (thanks to @akoeplinger for the suggestion), which causes
the param to explicitly set to false. Thus allowing runtime-staging
builds to be marked as such.

  • These jobs will now fail when their tests fail:

    • windows - library tests, and AOT
    • windows - WasmBuildTests
    • debugger tests for chrome

  • This will prevent errors getting missed, and merged because runtime-staging wasn't looked at

  • Also, add more paths to trigger tests on CI

Related: #73166

@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Aug 4, 2022
@ghost ghost assigned radical Aug 4, 2022
@ghost
Copy link

ghost commented Aug 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. false.

Currently, xplat-setup.yml passes on shouldContinueOnError to the
template with true if the parameter was true, else it sets the value
based on whether this is for runtime-staging, on a PR.

Which essentially means that runtime-staging defaults to
shouldContinueOnError: true for PRs, or we can set it explcitly to
true which would affect the rolling builds.

But this does not allow making a runtime-staging job fail when tests
fail. To support that this change adds a check for a special value
forceFalse (thanks to @akoeplinger for the suggestion), which causes
the param to explicitly set to false. Thus allowing runtime-staging
builds to be marked as such.

  • Also, add more paths to trigger tests on CI
Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@radical radical marked this pull request as draft August 4, 2022 20:46
radical added 2 commits August 5, 2022 02:57
@radical
xplat-setup.yml: Add support for setting shouldContinueOnError to
522a01f 
.. `false`.

Currently, xplat-setup.yml passes on `shouldContinueOnError` to the
template with `true` if the parameter was `true`, else it sets the value
based on whether this is for runtime-staging, on a PR.

Which essentially means that runtime-staging defaults to
`shouldContinueOnError: true` for PRs, or we can set it explcitly to
`true` which would affect the rolling builds.

But this does not allow making a runtime-staging job *fail* when *tests
fail*. To support that this change adds a check for a special value
`forceFalse`, which causes the param to explicitly set to `false`. Thus
allowing `runtime-staging` builds to be marked as such.
@radical
[wasm] Add more paths to trigger running tests on CI
357f99d
@radical radical marked this pull request as ready for review August 5, 2022 02:57
@radical radical changed the title xplat-setup.yml: Add support for setting shouldContinueOnError to runtime-staging: Enable failed tests on stable jobs to fail the job Aug 5, 2022
@radical radical added this to the 7.0.0 milestone Aug 5, 2022
This was referenced Aug 5, 2022
Closed
Closed
akoeplinger
akoeplinger approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after making the changes we discussed on Discord

@radical
Copy link
Member Author

radical commented Aug 8, 2022

LGTM after making the changes we discussed on Discord

As discussed, I'll move the stable wasm jobs from runtime-staging to runtime, in a follow up PR. And am merging this one.

@radical radical merged commit 11f162a into dotnet:main Aug 8, 2022
@radical radical deleted the ci-fixes branch August 8, 2022 19:24
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@lewing lewing Awaiting requested review from lewing

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @akoeplinger