Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NullabilityInfoContext behavior for ByRef types. #73520

Merged
merged 7 commits into from
Aug 12, 2022

Conversation

madelson
Copy link
Contributor

@madelson madelson commented Aug 6, 2022

fix #72320

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 6, 2022
@ghost
Copy link

ghost commented Aug 6, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

fix #72320

Author: madelson
Assignees: -
Labels:

area-System.Reflection

Milestone: -

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you for adding a broad range of testing @madelson!

@buyaa-n
Copy link
Contributor

buyaa-n commented Aug 12, 2022

Failures unrelated, one of the failures related to nuget package availability, filed an issue for other

@buyaa-n buyaa-n merged commit ec0662c into dotnet:main Aug 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not get NullabilityInfo of out/ref parameters
3 participants