-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify platform macro definitions in PAL #73530
Simplify platform macro definitions in PAL #73530
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
16839f6
to
28204ea
Compare
@janvorli, the CI issue was fixed after the rebase. PTAL. |
@am11 I am sorry for the delay, I was OOF for the last 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@EgorBo, any idea why superpmi leg would fail the osx-arm64 checks when I updated
The CI was green before |
@am11 we had some issues with it and fixed them yesterday, can you rebase your PR? |
@am11 let me retry the superpmi tests one more time and then I'll merge it. |
It was missed in dotnet#73530, before that we defined `HOST_ARM` for armv6 in pal.h too because of `defined(__arm__)`
Add missing HOST_ARM define to armv6 in configurecompiler.cmake, it was missed in #73530, before that we defined `HOST_ARM` for armv6 in pal.h too because of `defined(__arm__)` We also only need the `clr.iltools+clr.packages` subset, not all of CoreCLR. Also fix some dependencies that weren't working for FreeBSD since we missed the local variables. We don't need installer subset conditions there but we need to trigger on rolling builds.
_M_{ARCH}
definitions and replace usage withHOST_{ARCH}
andTARGET_{ARCH}
.${arch}
from filenames in architecture specific directories.Arm
fromPAL_ArmInterlockedOperationBarrier
andArmInterlockedOperationBarrier
as they are not ARM-specific anymore.src/coreclr/build-runtime.sh -cross -a riscv64 -component paltests
(without running into missing files errors).