Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BN_is_zero for OpenSSL 1.0.2 non-portable build #79369

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Dec 7, 2022

I checked this change against CentOS 7.

Before this change, running build-native.sh -portableBuild=false would produce:

#define BN_is_zero local_BN_is_zero
        ^
/usr/include/openssl/bn.h:403:10: note: previous definition is here
# define BN_is_zero(a)       ((a)->top == 0)

After this change, I am able to do a non-portable build successfully. This issue was introduced in #79013 (comment).

/cc @mmitche

@ghost
Copy link

ghost commented Dec 7, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

I checked this change against CentOS 7.

Before this change, running build-native.sh -portableBuild=false would produce:

#define BN_is_zero local_BN_is_zero
        ^
/usr/include/openssl/bn.h:403:10: note: previous definition is here
# define BN_is_zero(a)       ((a)->top == 0)

After this change, I am able to do a non-portable build successfully. This issue was introduced in #79013 (comment).

/cc @mmitche

Author: vcsjones
Assignees: vcsjones
Labels:

area-System.Security

Milestone: -

@vcsjones vcsjones merged commit 5b8a981 into dotnet:main Dec 8, 2022
@vcsjones vcsjones deleted the fix-nonportable-build branch December 8, 2022 02:00
@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants