Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createdump arg parsing for signal-based exceptions #85422

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Apr 26, 2023

No description provided.

@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: hoyosjs
Assignees: hoyosjs
Labels:

area-Diagnostics-coreclr

Milestone: -

@hoyosjs
Copy link
Member Author

hoyosjs commented Apr 26, 2023

/backport to release/7.0-staging

@hoyosjs
Copy link
Member Author

hoyosjs commented Apr 26, 2023

/backport to release/6.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4813695249

@github-actions
Copy link
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/4813696243

Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

@hoyosjs backporting to release/6.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix createdump arg parsing for signal-based exceptions
Using index info to reconstruct a base tree...
M	src/coreclr/debug/createdump/createdump.h
M	src/coreclr/debug/createdump/main.cpp
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/debug/createdump/main.cpp
CONFLICT (content): Merge conflict in src/coreclr/debug/createdump/main.cpp
Auto-merging src/coreclr/debug/createdump/createdump.h
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix createdump arg parsing for signal-based exceptions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@hoyosjs an error occurred while backporting to release/6.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@tommcdon tommcdon requested a review from mikem8361 April 26, 2023 21:55
Copy link
Member

@mikem8361 mikem8361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoyosjs hoyosjs merged commit 94f2b65 into dotnet:main Apr 27, 2023
@hoyosjs hoyosjs deleted the juhoyosa/fix-createdump-args branch April 27, 2023 22:15
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants