JIT: Clean up some call multi-reg ret handling #99679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch some `IsMultiRegReturnedType` calls to use `GenTreeCall::HasMultiRegRetVal`. - Remove `Compiler*` parameter of `TreatAsShouldHaveRetBufArg`; the function it was using on `Compiler` is static
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
src/coreclr/jit/fginline.cpp
Outdated
| @@ -405,55 +395,23 @@ class SubstitutePlaceholdersAndDevirtualizeWalker : public GenTreeVisitor<Substi | |||
| // candidates. | |||
| // | |||
| // Do the deferred work now. | |||
| if (retClsHnd != NO_CLASS_HANDLE) | |||
| if ((*use)->IsCall() && (*use)->AsCall()->HasMultiRegRetVal()) | |||
There was a problem hiding this comment.
Does this not cause diffs on platforms with multi-reg LONG returns?
There was a problem hiding this comment.
The 32 bit builds certainly look unhappy.
There was a problem hiding this comment.
It was causing us to call lvaSetStruct(..., nullptr, ...) and hit an assert. Added a varTypeIsStruct check back here now.
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Ping @EgorBo |
EgorBo
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsMultiRegReturnedTypecalls to useGenTreeCall::HasMultiRegRetVal.Compiler*parameter ofTreatAsShouldHaveRetBufArg; the function it was using onCompileris static