-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeAOT/win-x86: Enable FEATURE_EH_CALLFINALLY_THUNKS #99718
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
src/tests/JIT/jit64/eh/basics/throwinfinallyintryfilter2.ilproj
Outdated
Show resolved
Hide resolved
cc @dotnet/jit-contrib |
I run into some issues that may be related to this. For example, |
Turns out the issue is unrelated to this change. It's simply lack of |
@BruceForstall perhaps you should take a look? |
This is hopefully the last missing piece for the win-x86 NativeAOT support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
Note that it is changing exception handling behavior of the existing Linux/x86 support. We don't build or test that (that I know of), and comments here indicate Linux/x86 is already broken for other reasons, so perhaps this adds yet another thing that either improves the existing state or adds to the backlog. In any case, it makes sense that x86 with funclets and x64 with funclets are on the same plan.
Fixes #99687