Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Fix Swift multireg stores in presence of GT_RELOAD #99789

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jakobbotsch
Copy link
Member

I accidentally merged #99704 before the jitstressregs jobs I had kicked off were actually done running. This fixes an issue caught by those pipelines.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 14, 2024
@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @amanasifkhalid

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes. Thanks!

@jakobbotsch
Copy link
Member Author

There is another failure, but it looks LSRA related and unrelated to the specifics of Swift handling. Going to open a separate issue for it.

@jakobbotsch jakobbotsch merged commit 334020d into dotnet:main Mar 15, 2024
197 of 207 checks passed
@jakobbotsch jakobbotsch deleted the fix-swift-offsets-reloads branch March 15, 2024 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants