Remove System.Runtime.Loader dependency on netstandard #8065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8061 Avoid .NET Standard 1.x dependencies in the repo completely. This results in this repo not being affected by CVEs / vulnerable packages like System.Private.Uri that are part of the .NET Standard 1.x dependency graph. Upgrade projects that use "System.Runtime.Loader" from netstandard2.0 to .NETCoreApp as that API is only availble on .NETCoreApp but keep the netstandard2.0 TFM. The Loader package that was used hasn't shipped for years anymore and was never intended to be used on .NET Standard (support for it was later removed) Because of that, new nullable reference type errors were raised by the compiler which I suppressed temporarily by downgrading the Nullable property to "annotations".
akoeplinger
approved these changes
Jun 10, 2024
…aderDependencyFromNetStandard
akoeplinger
approved these changes
Jun 10, 2024
ViktorHofer
deleted the
RemoveSystemRuntimeLoaderDependencyFromNetStandard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: This needs my other PRs in this repo to be merged first.
Fixes #8061
Avoid .NET Standard 1.x dependencies in the repo
completely. This results in this repo not being
affected by CVEs / vulnerable packages like
System.Private.Uri that are part of the .NET
Standard 1.x dependency graph.
Upgrade projects that use "System.Runtime.Loader"
from netstandard2.0 to .NETCoreApp as that API is
only availble on .NETCoreApp but keep the
netstandard2.0 TFM. The Loader package that was
used hasn't shipped for years anymore and was
never intended to be used on .NET Standard
(support for it was later removed)
Because of that, new nullable reference type
errors were raised by the compiler which I
suppressed temporarily by downgrading the
Nullable property to "annotations".