Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetCurrent TFMs and make task pkg target runtimes #8104

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ViktorHofer
Copy link
Member

... instead of .NET Standard.

  1. Add NetCurrent TFMs to projects that only targeted .NET Standard or .NET Framework. This improves perf and trims the dependency graph when building templating from source.
  2. Change the netstandard2.0 TFM in the task project to NetToolCurrent and NetFrameworkToolCurrent to avoid including assemblies in the package that are already provided by the runtime. This resolves issues with deps.json false positives but also reduces the need for servicing the package in the event of an CVE.

... instead of .NET Standard.

1. Add NetCurrent TFMs to projects that only
   targeted .NET Standard or .NET Framework. This
   improves perf and trims the dependency graph
   when building templating from source.
2. Change the netstandard2.0 TFM in the task project
   to NetToolCurrent and NetFrameworkToolCurrent
   to avoid including assemblies in the package
   that are already provided by the runtime.
   This resolves issues with deps.json false
   positives but also reduces the need for servicing
   the package in the event of an CVE.
@ViktorHofer ViktorHofer requested a review from a team as a code owner June 12, 2024 11:02
@ViktorHofer ViktorHofer merged commit fab5ef4 into main Jun 12, 2024
10 checks passed
@ViktorHofer ViktorHofer deleted the AddNetCurrentAndMakeTaskPackageTargetRuntimes branch June 12, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants