Skip to content
This repository was archived by the owner on Sep 7, 2020. It is now read-only.

Angular 4 #160

Closed
amihailes opened this issue Mar 24, 2017 · 21 comments
Closed

Angular 4 #160

amihailes opened this issue Mar 24, 2017 · 21 comments

Comments

@amihailes
Copy link

Hi,

Is it possible to have an Angular 4 based build?

Thanks in advance,

Adrian

@dougludlow
Copy link
Owner

@amihailes ha ha, yes, it only came out last night, but I'm working on it.

@amihailes
Copy link
Author

Good news!

dougludlow pushed a commit that referenced this issue Apr 2, 2017
- Migrate project to angular-cli.
- Rename modalInstance to modalWrapper.
- Detect backdrop and keyboard with observables.
- Add ability to dismiss all modals (#161).
- Upgrade to Angular v4 (#160).
- Subscribe to all events (#157).
- Create umd/cjs bundle.
dougludlow pushed a commit that referenced this issue Apr 2, 2017
- Migrate project to angular-cli.
- Rename modalInstance to modalWrapper.
- Detect backdrop and keyboard with observables.
- Add ability to dismiss all modals (#161).
- Upgrade to Angular v4 (#160).
- Subscribe to all events (#157).
- Create umd/cjs bundle.
@ChadiEM
Copy link

ChadiEM commented Apr 10, 2017

It's perhaps the opportunity to rename the project to something like angular-bs3-modal. With Angular 4, Google is suggesting to remove the Angular version from the libraries.

@assaulter
Copy link
Contributor

oh, ng2-bootstrap was renamed to ngx-bootstrap.

@grichards23
Copy link

I just tried upgrading my project to angular 4, before doing so I made sure to have the latest ng2-b3-modal component.

npm is throwing peer dependency warnings that [email protected] requires angular ^2.0.0 versions.

Can I safely ignore these?

@dougludlow
Copy link
Owner

@assaulter yes, I'll probably follow suit here shortly.

@dougludlow
Copy link
Owner

@grichards23 - I believe you can. I'm working on trying to get an Angular v4 version out, just haven't had a whole lot of time lately.

@wartab
Copy link

wartab commented Apr 18, 2017

@grichards23 I have no trouble besides the peer dependencies not meeting the requirements. It works perfectly fine!

@ghost
Copy link

ghost commented May 16, 2017

Hey @dougludlow Can you please upgrade the repo to support angular4 and bs4? I am using ng2-bs3-modal in my project which uses angular4. I am planning on upgrading my project to BS4. So it will be better if ng2-bs3-modal supports all the dependencies. Thank you in advance.

@Stefan-Aurea
Copy link

Hey @dougludlow , I am curious as to how you're using ng2-bs3-modal with angular4 given that the current version has a peerDependency on angular@^2.0.0

...this is in fact what is blocking me right now.

@wartab
Copy link

wartab commented Jun 12, 2017

Peer dependency error messages are warnings, not errors. You can safely ignore them.

@Stefan-Aurea
Copy link

Got it, thanks @wartab, I guess I'm just one of those perfectionists who hate warnings ;) I like clean output :)

@wartab
Copy link

wartab commented Jun 12, 2017

It's clean if you close your eyes :)

@wartab
Copy link

wartab commented Jun 12, 2017

But I agree, the peer-dependencies should be ^2.0.0 || ^4.0.0

@amitdahan
Copy link

@dougludlow any news? Last we heard of this was April :)

@equipe404
Copy link

It works but the warnings make it impossible to use npm shrinkwrap.

Peer dependencies should be ^2.0.0 || ^4.0.0 and that would fix the issue.

@marslan2037
Copy link

any solution for this?

@darekurlik
Copy link

+1 Please fix it as suggested by equipe404

have problems as follows:
npm ERR! peer invalid: @angular/common@^2.0.0, required by [email protected]
npm ERR! peer invalid: @angular/compiler@^2.0.0, required by [email protected]
npm ERR! peer invalid: @angular/core@^2.0.0, required by [email protected]
npm ERR! peer invalid: @angular/platform-browser@^2.0.0, required by [email protected]
npm ERR! peer invalid: @angular/platform-browser-dynamic@^2.0.0, required by [email protected]

@Stefan-Aurea
Copy link

This seems already fixed on Master... any chance it can be released?

@dougludlow
Copy link
Owner

@Stefan-Aurea I've got it released finally as v0.11.5. Enjoy.

@Stefan-Aurea
Copy link

Awesome! Thank you very much @dougludlow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests