-
Notifications
You must be signed in to change notification settings - Fork 133
Angular 4 #160
Comments
@amihailes ha ha, yes, it only came out last night, but I'm working on it. |
Good news! |
It's perhaps the opportunity to rename the project to something like angular-bs3-modal. With Angular 4, Google is suggesting to remove the Angular version from the libraries. |
oh, ng2-bootstrap was renamed to ngx-bootstrap. |
I just tried upgrading my project to angular 4, before doing so I made sure to have the latest ng2-b3-modal component. npm is throwing peer dependency warnings that [email protected] requires angular ^2.0.0 versions. Can I safely ignore these? |
@assaulter yes, I'll probably follow suit here shortly. |
@grichards23 - I believe you can. I'm working on trying to get an Angular v4 version out, just haven't had a whole lot of time lately. |
@grichards23 I have no trouble besides the peer dependencies not meeting the requirements. It works perfectly fine! |
Hey @dougludlow Can you please upgrade the repo to support angular4 and bs4? I am using ng2-bs3-modal in my project which uses angular4. I am planning on upgrading my project to BS4. So it will be better if ng2-bs3-modal supports all the dependencies. Thank you in advance. |
Hey @dougludlow , I am curious as to how you're using ...this is in fact what is blocking me right now. |
Peer dependency error messages are warnings, not errors. You can safely ignore them. |
Got it, thanks @wartab, I guess I'm just one of those perfectionists who hate warnings ;) I like clean output :) |
It's clean if you close your eyes :) |
But I agree, the peer-dependencies should be ^2.0.0 || ^4.0.0 |
@dougludlow any news? Last we heard of this was April :) |
It works but the warnings make it impossible to use npm shrinkwrap. Peer dependencies should be ^2.0.0 || ^4.0.0 and that would fix the issue. |
any solution for this? |
+1 Please fix it as suggested by equipe404 have problems as follows: |
This seems already fixed on Master... any chance it can be released? |
@Stefan-Aurea I've got it released finally as v0.11.5. Enjoy. |
Awesome! Thank you very much @dougludlow |
Hi,
Is it possible to have an Angular 4 based build?
Thanks in advance,
Adrian
The text was updated successfully, but these errors were encountered: