Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix range theme fromjson #4795

Merged
merged 1 commit into from
Mar 8, 2025
Merged

fix: fix range theme fromjson #4795

merged 1 commit into from
Mar 8, 2025

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Mar 8, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested review from wzhudev and VicKun4937 as code owners March 8, 2025 11:35
Copy link

github-actions bot commented Mar 8, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Mar 8, 2025

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 7 seconds
commit  99a8a88
info  For more information, see full report

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 32.56%. Comparing base (b366151) to head (99a8a88).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets/src/model/range-theme-model.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4795      +/-   ##
==========================================
+ Coverage   32.54%   32.56%   +0.01%     
==========================================
  Files        2611     2611              
  Lines      136289   136284       -5     
  Branches    30295    30294       -1     
==========================================
+ Hits        44359    44380      +21     
+ Misses      91930    91904      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ybzky ybzky merged commit d2a4e12 into dev Mar 8, 2025
9 checks passed
@ybzky ybzky deleted the fix-range-theme-fromjson branch March 8, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants