Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added filtering options on mavcan #20

Merged
merged 3 commits into from
Feb 14, 2022
Merged

added filtering options on mavcan #20

merged 3 commits into from
Feb 14, 2022

Conversation

tridge
Copy link
Member

@tridge tridge commented Feb 14, 2022

added UI elements for filtering and bus number
image

@tridge tridge requested a review from davidbuzz February 14, 2022 07:32
@davidbuzz
Copy link
Member

Since this is going to rely on pydronecan 1.0.10 for these gui features to work, the dependancy should be moved forward...

gui_tool/setup.py

Line 44 in 3d6b739

'dronecan>=1.0.7',

davidbuzz
davidbuzz reviewed Feb 14, 2022
View reviewed changes
Copy link
Member

@davidbuzz davidbuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the setup.py is included, i'm ok with this., lets call it merge-on-setup.py-included.

@tridge
Copy link
Member Author

tridge commented Feb 14, 2022

once the setup.py is included, i'm ok with this., lets call it merge-on-setup.py-included.

fixed

@tridge tridge merged commit ac17b62 into dronecan:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbuzz davidbuzz davidbuzz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tridge @davidbuzz