Hooks improvement #11
Merged
+181
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilamanov
commented
Jan 16, 2025
src/duneApi.ts
Outdated
| @@ -5,9 +5,9 @@ import { | |||
| TransactionsParams, | |||
| } from "./types"; | |||
|
|
|||
| const BALANCE_API_BASE_URL = "https://api.dune.com/api/echo/v1/balances/evm/"; | |||
| const BALANCE_API_BASE_URL = "https://api.dune.com/api/echo/v1/balances/evm"; | |||
There was a problem hiding this comment.
Having these slashes here means we have a double slash in the api url (see below in this file)
ilamanov
commented
Jan 16, 2025
src/useTokenBalances.ts
Outdated
| @@ -24,7 +25,7 @@ export const useTokenBalances = ( | |||
| useEffect(() => { | |||
| if (!apiKey) return; | |||
| const fetchDataAsync = async () => { | |||
| if (!walletAddress) return; | |||
| if (!walletAddress || !isAddress(walletAddress)) return; | |||
There was a problem hiding this comment.
small optimization - we don't need to run this when the address is invalid
ilamanov
commented
Jan 16, 2025
src/useTransactions.ts
Outdated
| @@ -29,7 +30,7 @@ export const useTransactions = ( | |||
|
|
|||
| // Function to fetch data for a specific page | |||
| const fetchDataAsync = async (offset: string | null) => { | |||
| if (!walletAddress) return; | |||
| if (!apiKey || !walletAddress || !isAddress(walletAddress)) return; | |||
There was a problem hiding this comment.
small optimization - we don't need to run this when the address is invalid or the api key is missing
GarrettJMU
approved these changes
Jan 17, 2025
ilamanov
changed the base branch from
01-15-set_up_vitest_testing
to
graphite-base/11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added inline comments but mostly small optimizations, bug fixes