Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new alloc panic handling #193

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Support new alloc panic handling #193

merged 2 commits into from
Apr 26, 2023

Conversation

HDauven
Copy link
Member

@HDauven HDauven commented Apr 25, 2023

This commit:

  • Removes the old alloc_panic_handler feature flag.
  • Removes the custom alloc panic handler.
  • Ups the Rust nightly toolchain version.

Resolves #192

@HDauven
Support new alloc panic handling
c1810a2 
This commit:
- Removes the old `alloc_panic_handler` feature flag.
- Removes the custom alloc panic handler.
- Ups the Rust nightly toolchain version.
@HDauven HDauven added fix:bug Something isn't working mark:next Strategic issues related to next versions of Testnet and mid/long term plans team:Core Low Level Core Development Team (Rust) labels Apr 25, 2023
@HDauven HDauven requested review from miloszm and ureeves April 25, 2023 23:15
@HDauven HDauven self-assigned this Apr 25, 2023
@HDauven HDauven marked this pull request as ready for review April 25, 2023 23:16
ureeves
ureeves approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just missing a changelog entry!

@HDauven
Update uplink changelog
548b3d6 
Add both `alloc_error_handler` remove and uplink types doc entry.
@HDauven
Copy link
Member Author

HDauven commented Apr 26, 2023

LGTM. Just missing a changelog entry!

Thanks for the reminder! Also added a missing entry for #139.

@HDauven HDauven requested a review from ureeves April 26, 2023 07:40
@HDauven HDauven merged commit 9e0ca26 into main Apr 26, 2023
@HDauven HDauven deleted the remove-alloc-error-handler-192 branch April 26, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszm miloszm Awaiting requested review from miloszm

@ureeves ureeves Awaiting requested review from ureeves

Assignees

@HDauven HDauven

Labels
fix:bug Something isn't working mark:next Strategic issues related to next versions of Testnet and mid/long term plans team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alloc error handler removed
2 participants
@HDauven @ureeves