Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cb2-13154): Provide a '‘centralDocs'' object for VTx #410

Merged
merged 11 commits into from
Jul 26, 2024

Conversation

Daniel-Searle
Copy link
Contributor

@Daniel-Searle Daniel-Searle commented Jul 22, 2024

Provide a '‘centralDocs'' object for VTx

  1. This change is to add in the central docs object into the request and response types inside of test types.
  2. All of the vehicle types schemas needed to be updated to include the central doc object as well as the PUT schemas.
  • PSV
  • HGV
  • TRL
  • CAR
  • MOTORBIKE
  • LGV
  1. A new enum has been added that contains all of the test type id's that require a central docs object to be present.
  2. New functions that are used to identify if a test type is a central doc test type and apply custom validation on the test type.
  3. New integration test file, testing validation error messages.
  4. Test result JSON files have been updated to include the new object for both of the appropriate requests and responses.
  5. Added in new unit tests to validate that the new helper functions are functioning from a function level, as well as testing them in isolation.
  6. Utilise the test type id's from the common repo same as the helper method.
  7. Validation to throw an error, when the test type shouldn't have the central doc object.

CB2-13154

Checklist

  • Code has been tested manually
  • PR title includes the JIRA ticket number
  • Branch is rebased against the latest develop
  • Squashed commit contains the JIRA ticket number

@Daniel-Searle Daniel-Searle changed the title feat(cb2-13154): added centralDoc object and validators + linting feat(cb2-13154): Provide a '‘centralDocs'' object for VTx Jul 22, 2024
@Daniel-Searle Daniel-Searle requested a review from cb-cs July 24, 2024 13:33
@cb-cs cb-cs self-requested a review July 25, 2024 06:56
@cb-cs cb-cs merged commit 6f2c245 into develop Jul 26, 2024
4 checks passed
@cb-cs cb-cs deleted the feature/CB2-13154 branch July 26, 2024 09:00
LGin-BJSS added a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants