-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cb2 11709 test: remove nested integration tests #94
Conversation
Nice work, happy to approve once we look into the single line suggestion I made :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Would be amazing to run these in the pipeline pre merge to make sure it's happy with the changes. https://github.com/dvsa/cvs-devops/actions -> this repo has all the actions needed to build a feature env and make sure that you're working. Think you just need to run the new-code-cut job |
Started this run: https://github.com/dvsa/cvs-devops/actions/runs/8878463350 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice one!
Description
Related issue: 11709
Before submitting (or marking as "ready for review")