Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cb2 11709 test: remove nested integration tests #94

Merged
merged 18 commits into from
Apr 30, 2024

Conversation

FurkanErdogan-BJSS
Copy link
Contributor

@FurkanErdogan-BJSS FurkanErdogan-BJSS commented Apr 22, 2024

Description

  • Remove nested integration tests
  • Move unit test execution to pre-commit
  • Fix vulnerabilities
  • Fix ci issues regarding package versions
  • Remove --coverage from integration test execution in workflow to avoid heap memory issue
  • Update jest configs to categorise unit and integration tests
  • Add vscode jest settings to enable executing integration tests from vscode
  • Add jest-serial-runner to allow sequential tests execution for integration tests

Related issue: 11709

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@Nat-McCabe-BJSS
Copy link
Contributor

Nice work, happy to approve once we look into the single line suggestion I made :)

Copy link

@meys-bjss meys-bjss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@naathanbrown
Copy link
Contributor

Would be amazing to run these in the pipeline pre merge to make sure it's happy with the changes. https://github.com/dvsa/cvs-devops/actions -> this repo has all the actions needed to build a feature env and make sure that you're working. Think you just need to run the new-code-cut job

@FurkanErdogan-BJSS
Copy link
Contributor Author

Would be amazing to run these in the pipeline pre merge to make sure it's happy with the changes. https://github.com/dvsa/cvs-devops/actions -> this repo has all the actions needed to build a feature env and make sure that you're working. Think you just need to run the new-code-cut job

Started this run: https://github.com/dvsa/cvs-devops/actions/runs/8878463350
not 100% sure if I did it correctly though.

naathanbrown
naathanbrown previously approved these changes Apr 30, 2024
Copy link
Contributor

@Nat-McCabe-BJSS Nat-McCabe-BJSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice one!

@FurkanErdogan-BJSS FurkanErdogan-BJSS merged commit b63a1c6 into develop Apr 30, 2024
6 checks passed
@FurkanErdogan-BJSS FurkanErdogan-BJSS deleted the feature/CB2-11709 branch April 30, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants