-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate dependencies of 11ty #164
Comments
|
You may want to consider switching to node-watch by @yuanchuan. I did this for QUnit back in 2018 and it helped us reduce dependencies from 142 to 9. https://qunitjs.com/blog/2019/01/06/qunit-2-9-0/
Pull request: qunitjs/qunit#1345 |
@Krinkle what is the advantage over choking v4? It doesn't seem to support globs only filters. And filters don't cut it when watching directories because they will filter out subdirs that don't match the glob (even tho they could have files that do match the glob) |
Note that chokidar currently has 1 dependency. Times have changed since you switched 👀 I'm biased since I maintain it but I would just stick with it and benefit from the de-dupe |
@Fuzzyma Filtering out one result and recursively skipping an entire directory, are two different things. I haven't tried it recently, but the readme sounds like Chokidar made the same decision as node-watch. https://github.com/paulmillr/chokidar/tree/4.0.3 reads:
... except node-watch does still support the optmization to skip subtrees when desired. This becomes less relevant over time, but it's there today.
@43081j I'm glad Chokidar was able to make such a drastic change. That benefits a huge portion of the ecosystem. Very nice! Ultimately, I suppose the key question for this issue is: What does Eleventy actually need? |
Chokidar v4 also allows filtering via ignore and it will filter out any subtree you want. However, this is unfortunately not a replacement for globs as i experienced painfully. Not shooting against node-watch here. Just wanted to make sure that the capabilities are understood :) // Edit: actually looked at the docs now and it seems that node-watch allows to skip items more granualy than chokidar by returning false / "skip" |
Let's find out what 11ty currently uses chokidar for and go from there There's still opportunity to add new functionality to chokidar but I suspect 11ty won't need that |
https://github.com/11ty/eleventy/blob/main/package.json
Zach seems happy to do some maintenance here, so we should take a look.
Obvious ones:
We are going to track this in an equivalent umbrella issue inside the eleventy repo. So do not make individual issues unless Zach decides to pull one out of the umbrella to focus on.
The text was updated successfully, but these errors were encountered: