Replace glob packages with lighter alternatives – fast-glob + is-glob -> tinyglobby, micromatch -> picomatch
#3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pralkarz
commented
Mar 8, 2025
Comment on lines
-196
to
-234
| test("Bad expected output, this indicates a bug upstream in a dependency (update, was fixed in [email protected]). Input to 'src' and empty includes dir (issue #403, full paths in eleventyignore)", async (t) => { | ||
| let eleventyConfig = await getTemplateConfigInstanceCustomCallback({ | ||
| input: "test/stubs-403", | ||
| output: "_site", | ||
| includes: "", | ||
| data: false, | ||
| }, function(eleventyConfig) { | ||
| eleventyConfig.setUseGitIgnore(false); | ||
| }); | ||
|
|
||
| let { eleventyFiles: evf } = getEleventyFilesInstance(["liquid"], eleventyConfig); | ||
| evf._setEleventyIgnoreContent("!" + TemplatePath.absolutePath("test/stubs-403/_includes") + "/**"); | ||
| evf.init(); // duplicate init | ||
|
|
||
| t.deepEqual(await evf.getFiles(), [ | ||
| "./test/stubs-403/template.liquid", | ||
| // UPDATE: this was fixed in [email protected] | ||
| // This should be excluded from this list but is not because the ignore content used an absolutePath above. | ||
| // "./test/stubs-403/_includes/include.liquid", | ||
| ]); | ||
| }); | ||
|
|
||
| test("Workaround for Bad expected output, this indicates a bug upstream in a dependency. Input to 'src' and empty includes dir (issue #403, full paths in eleventyignore)", async (t) => { | ||
| let eleventyConfig = await getTemplateConfigInstanceCustomCallback({ | ||
| input: "test/stubs-403", | ||
| output: "_site", | ||
| includes: "", | ||
| data: false, | ||
| }, function(eleventyConfig) { | ||
| eleventyConfig.setUseGitIgnore(false); | ||
| }); | ||
|
|
||
| let { eleventyFiles: evf } = getEleventyFilesInstance(["liquid"], eleventyConfig); | ||
| evf._setEleventyIgnoreContent("!./test/stubs-403/_includes/**"); | ||
| evf.init(); // duplicate init | ||
|
|
||
| t.deepEqual(await evf.getFiles(), ["./test/stubs-403/template.liquid"]); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I removed these tests as from what I gather they were related to a bug in an old fast-glob version. Down to add them back as a sanity check though.
| t.deepEqual(evf.getRawFiles(), ["./test/stubs/writeTest/**/*.{liquid,md}"]); | ||
| t.true(files.length > 0); | ||
| t.is(files[0], "./test/stubs/writeTest/test.md"); | ||
| t.is(files[0], "test/stubs/writeTest/test.md"); |
There was a problem hiding this comment.
In production, the leading ./s always get added, this is a tests-only change. I can also mimic the expected behavior by mapping on line 135 if you'd prefer that rather than changing the assertion. Same goes for other changes like this.
Comment on lines
+260
to
+261
| // Swapped to `micromatch` in 3.0.0-alpha.17, and later to `picomatch`. | ||
| // The test can stay as a sanity check. |
There was a problem hiding this comment.
I wasn't sure what to do with this comment, so suggestions welcome! 😄
Comment on lines
+103
to
104
| // `fast-glob` isn't used any more, but the test can stay as a sanity check. | ||
| test("fastglob assumptions", async (t) => { |
There was a problem hiding this comment.
Please let me know whether you'd rather remove this entirely.
Ryuno-Ki
reviewed
Mar 10, 2025
Ryuno-Ki
reviewed
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the lately ongoing e18e efforts (e18e/ecosystem-issues#164).
package-lockdoesn't change much, but the heavier dependencies become dev-only.