remove lag after 1st time opening hats #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… listeners since it made slecting hats impossible
Jakubk15
approved these changes
Jan 3, 2025
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr removes the lag with opening the hat tab after the 1st time opening it. Object instantiating and looping through all the hats is not done after the 1st time once all the hats are cached. The hats then change parents between the hat tab and 1 of our own objects
current known bug with unknown solution: when changing from the any tab to the hat tab after the first time, an System.ArgumentException is thrown, and the previous's tab's contents also show up.
changing from color -> hat or hat -> any other tab is fine
changing from any tab except color -> hats causes a visual bug
the user has to go to color first to get to hats