Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupOnX #32

Merged
merged 6 commits into from
Aug 3, 2017
Merged

Fix groupOnX #32

merged 6 commits into from
Aug 3, 2017

Conversation

sherrillmix
Copy link
Collaborator

@sherrillmix sherrillmix commented Aug 3, 2017

A bug fix for issue #31 of potential unexpected consequences of the auto axis selection in groupOnX. Reverting to a simple default of grouping on x-axis unless specified.

  • Change the default of groupOnX to TRUE (using a NULL default with a is.null() in position_XX so we can detect if unset through the chain of functions)
  • If groupOnX unspecified and y-axis would previously have been selected then throw a warning
  • Update vignette
  • Update README

@eclarke eclarke merged commit eba17b0 into master Aug 3, 2017
@eclarke eclarke deleted the fixGroupOnX branch August 3, 2017 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants