Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Revert install sysconfdir handling #2068

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

Peguen
Copy link
Contributor

@Peguen Peguen commented Mar 7, 2025

Description

For PPA build the previous approach was necessary in order to create the config directory in the target directory of /etc/ecal/* . Right now, to have a backup configuration and to be consistent with the linux handling, we revert the change and make some small adaptations, e.g. that the install directory in windows will remain the "etc" folder and that on linux the path specifed by CMAKE_INSTALL_SYSCONFDIR will not be parsed for yaml configuration.

For installing via specified install dir (e.g. with the CMakePresets.json), the path that will be used if no yaml is at the preferred places is librarydir/../etc/ecal now for linux.

@Peguen Peguen added the cherry-pick-to-NONE Don't cherry-pick these changes label Mar 7, 2025
@Peguen Peguen merged commit 8887c57 into master Mar 7, 2025
27 of 28 checks passed
@Peguen Peguen deleted the hotfix/revert_install_sysconfdir_handling branch March 7, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants