Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: usage of the NoopTransactionContext in tests #1119

Closed
2 tasks done
paullatzelsperger opened this issue Apr 12, 2022 · 0 comments · Fixed by #1271
Closed
2 tasks done

Feature: usage of the NoopTransactionContext in tests #1119

paullatzelsperger opened this issue Apr 12, 2022 · 0 comments · Fixed by #1271
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@paullatzelsperger
Copy link
Member

Feature Request

Many of the SQL-related tests have to use a transaction context. Currently that means adding a gradle dependency onto the LocalTransactionContext and instantiating it in the @BeforeEach.

There already is a NoopTransactionManager that does nothing and is always available.

Which Areas Would Be Affected?

Tests, especially the SQL-tests

Why Is the Feature Desired?

Reduce inter-module dependencies

Solution Proposal

Use the NoopTransactionManager in all tests.

Type of Issue

cleanup

Checklist

  • assigned appropriate label?
  • Do NOT select a milestone or an assignee!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant