Feature: use NoopTransactionContext
in tests
#1271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR uses the
NoopTransactionContext
instead of theLocalTransactionContext
. In doing so it also replaces theLocalDataSourceRegistry
with a mock and removes the Apache connection pool instances from tests.Connections are simply kept open during each test method and closed afterwards.
Why it does that
To avoid inter-module dependencies and simplify test setups.
Further notes
In order to not have to wrap the entire
Connection
class, I opted for the usage of a Mockitospy
, that prevents connections from getting closed.Linked Issue(s)
Closes #1119
Checklist
no-changelog
)