Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataPlaneHttpToHttpIntegrationTests are flaky #1847

Closed
ndr-brt opened this issue Aug 18, 2022 · 0 comments · Fixed by #1849
Closed

DataPlaneHttpToHttpIntegrationTests are flaky #1847

ndr-brt opened this issue Aug 18, 2022 · 0 comments · Fixed by #1849
Assignees
Labels
bug Something isn't working flaky test
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Aug 18, 2022

Bug Report

Describe the Bug

DataPlaneHttpToHttpIntegrationTests are flaky:
https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/runs/7893124089

Expected Behavior

to be not flaky

e.g.

DataPlaneHttpToHttpIntegrationTests > transfer_WithSourceQueryParams_Success() FAILED
    java.lang.IllegalArgumentException: duplicate key: et
        at java.base/java.util.ImmutableCollections$MapN.<init>(ImmutableCollections.java:830)
        at java.base/java.util.Map.of(Map.java:1327)
        at org.eclipse.dataspaceconnector.dataplane.http.DataPlaneHttpToHttpIntegrationTests.transfer_WithSourceQueryParams_Success(DataPlaneHttpToHttpIntegrationTests.java:179)

Seems to be caused by Faker, as it could gave the same word as key for the map:
https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/blob/82891948f0ebe67de74390ae6a7510aeb6c053da/extensions/data-plane/integration-tests/src/test/java/org/eclipse/dataspaceconnector/dataplane/http/DataPlaneHttpToHttpIntegrationTests.java#L179-L182

@ndr-brt ndr-brt added bug Something isn't working flaky test labels Aug 18, 2022
@ndr-brt ndr-brt added this to the Milestone 6 milestone Aug 18, 2022
@ndr-brt ndr-brt changed the title DataPlaneHttpPullIntegrationTests is flaky DataPlaneHttpPullIntegrationTests are flaky Aug 18, 2022
@ndr-brt ndr-brt changed the title DataPlaneHttpPullIntegrationTests are flaky DataPlaneHttpToHttpIntegrationTests are flaky Aug 18, 2022
@ndr-brt ndr-brt self-assigned this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant