Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Faker from DataPlane integration tests #1849

Merged
merged 2 commits into from
Aug 19, 2022
Merged

fix: remove Faker from DataPlane integration tests #1849

merged 2 commits into from
Aug 19, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 18, 2022

What this PR changes/adds

Remove Faker from data plane integration tests, as it seems to make them flaky (see #1847)

Why it does that

To strengthen tests

Further notes

  • the DataPlaneHttpToHttpIntegrationTests seems to be more of a system-test than an integration test, since it run a launcher: data-plane-server
  • DataPlaneHttpPullIntegrationTests could stay in the data-plane-http module, since that's what it's testing

Linked Issue(s)

Closes #1847

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt added the bug Something isn't working label Aug 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1849 (f04b825) into main (8289194) will increase coverage by 6.77%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1849      +/-   ##
============================================
+ Coverage     60.72%   67.50%   +6.77%     
============================================
  Files           779      779              
  Lines         16608    16608              
  Branches       1085     1085              
============================================
+ Hits          10086    11211    +1125     
+ Misses         6101     4929    -1172     
- Partials        421      468      +47     
Impacted Files Coverage Δ
...iation/ProviderContractNegotiationManagerImpl.java 90.55% <0.00%> (+0.55%) ⬆️
.../api/multipart/handler/ArtifactRequestHandler.java 61.42% <0.00%> (+1.42%) ⬆️
...i/multipart/handler/DescriptionRequestHandler.java 72.54% <0.00%> (+1.96%) ⬆️
...patcher/sender/MultipartArtifactRequestSender.java 83.33% <0.00%> (+5.55%) ⬆️
...nder/MultipartCatalogDescriptionRequestSender.java 5.88% <0.00%> (+5.88%) ⬆️
...r/MultipartEndpointDataReferenceRequestSender.java 92.85% <0.00%> (+7.14%) ⬆️
.../policy/store/schema/SqlPolicyStoreStatements.java 92.30% <0.00%> (+7.69%) ⬆️
...nition/store/schema/postgres/CriterionMapping.java 14.28% <0.00%> (+14.28%) ⬆️
...s/store/schema/TransferProcessStoreStatements.java 100.00% <0.00%> (+17.85%) ⬆️
...on/store/schema/ContractNegotiationStatements.java 100.00% <0.00%> (+37.93%) ⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for getting rid of the faker everywhere!

@ndr-brt ndr-brt merged commit 5c51fc2 into eclipse-edc:main Aug 19, 2022
@ndr-brt ndr-brt deleted the fix/1847-fix-test branch August 19, 2022 08:37
janpmeyer pushed a commit to FraunhoferISST/edc-connector that referenced this pull request Aug 23, 2022
* fix: remove Faker from DataPlane integration tests

* Remove faker dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataPlaneHttpToHttpIntegrationTests are flaky
4 participants