fix: remove Faker from DataPlane integration tests #1849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove
Faker
from data plane integration tests, as it seems to make them flaky (see #1847)Why it does that
To strengthen tests
Further notes
DataPlaneHttpToHttpIntegrationTests
seems to be more of asystem-test
than an integration test, since it run alauncher
:data-plane-server
DataPlaneHttpPullIntegrationTests
could stay in thedata-plane-http
module, since that's what it's testingLinked Issue(s)
Closes #1847
Checklist
no-changelog
)