Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable integration tests against real S3 #1899

Closed
2 tasks done
iwasakims opened this issue Aug 29, 2022 · 2 comments · Fixed by #1951
Closed
2 tasks done

test: enable integration tests against real S3 #1899

iwasakims opened this issue Aug 29, 2022 · 2 comments · Fixed by #1951
Labels
enhancement New feature or request

Comments

@iwasakims
Copy link
Contributor

Feature Request

Integration based on AbstractS3Test are assuming http://localhost:9000 (provided by minio) as endpoint. It would be nice if we can run integration tests against real S3 endpoint based on test time configuration.

Which Areas Would Be Affected?

test, S3

Why Is the Feature Desired?

bugs related to specific S3 settings/regions could be found by running tests against real S3.

Solution Proposal

switching endpoint URI based on the environment variables.

Type of Issue

improvement

Checklist

  • assigned appropriate label?
  • Do NOT select a milestone or an assignee!
@iwasakims iwasakims added the enhancement New feature or request label Aug 29, 2022
@jimmarino
Copy link
Contributor

We've asked our friends at AWS to do this but have not had much traction.

iwasakims added a commit to iwasakims/DataSpaceConnector that referenced this issue Sep 12, 2022
@iwasakims
test: enable integration tests against real S3 (fixes eclipse-edc#1899)
8bf451a
@iwasakims iwasakims mentioned this issue Sep 12, 2022
Merged
5 tasks
@iwasakims
Copy link
Contributor Author

I submitted PR #1951 for running tests against S3 using my own AWS credential from my local environment.

paullatzelsperger pushed a commit that referenced this issue Sep 16, 2022
@iwasakims
test: enable integration tests against real S3 (fixes #1899) (#1951)
ad4a338 
* test: enable integration tests against real S3 (fixes #1899)

* avoid overwriting task settins of root project.

* refactored method checking MinIO availability.

* added documentation about running integration tests against S3.

* split method checking backend availability for readability.

* fixed invalid endpoint URL in example cmdline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: enable integration tests against real S3 (fixes #1899) iwasakims/DataSpaceConnector
2 participants
@jimmarino @iwasakims