Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid severe logging on AzureVault if secret is not found #1962

Closed
2 tasks done
ndr-brt opened this issue Sep 15, 2022 · 0 comments · Fixed by #1963
Closed
2 tasks done

Avoid severe logging on AzureVault if secret is not found #1962

ndr-brt opened this issue Sep 15, 2022 · 0 comments · Fixed by #1963
Labels
enhancement New feature or request
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Sep 15, 2022

Feature Request

Currently AzureVault logs an exception if the secret is not fount through the resolveSecret method.
It shouldn't, since it's something that needs to be evaluated from the client class (in some cases, e.g. DataPlaneS3Extension, if the credentials are not found in the vault they are loaded in a different way, so it's not an error).

Which Areas Would Be Affected?

azure vault

Why Is the Feature Desired?

Avoid misleading error logs

Solution Proposal

If possible, provide a (brief!) solution proposal.

Type of Issue

i.e., new feature, improvement, cleanup, etc.

Checklist

  • assigned appropriate label?
  • Do NOT select a milestone or an assignee!
@ndr-brt ndr-brt added the enhancement New feature or request label Sep 15, 2022
@ndr-brt ndr-brt added this to the Milestone 7 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant