-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avoid log azure vault #1963
Merged
ndr-brt
merged 5 commits into
eclipse-edc:main
from
ndr-brt:feature/1962-avoid-log-azure-vault
Sep 19, 2022
Merged
feat: avoid log azure vault #1963
ndr-brt
merged 5 commits into
eclipse-edc:main
from
ndr-brt:feature/1962-avoid-log-azure-vault
Sep 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...azure-vault/src/main/java/org/eclipse/dataspaceconnector/core/security/azure/AzureVault.java
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
+ Coverage 62.80% 62.97% +0.17%
==========================================
Files 782 782
Lines 16616 16643 +27
Branches 1080 1081 +1
==========================================
+ Hits 10435 10481 +46
+ Misses 5730 5712 -18
+ Partials 451 450 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
...azure-vault/src/main/java/org/eclipse/dataspaceconnector/core/security/azure/AzureVault.java
Show resolved
Hide resolved
...azure-vault/src/main/java/org/eclipse/dataspaceconnector/core/security/azure/AzureVault.java
Outdated
Show resolved
Hide resolved
ronjaquensel
approved these changes
Sep 16, 2022
paullatzelsperger
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Avoid "severe" log on
AzureVault
when secret is not found.Why it does that
To avoid misleading logs
Further notes
resolveSecret
methodCountDownLatch
onAzureVaultExtensionTest
Linked Issue(s)
Closes #1962
Checklist
no-changelog
)