Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid log azure vault #1963

Merged
merged 5 commits into from
Sep 19, 2022
Merged

feat: avoid log azure vault #1963

merged 5 commits into from
Sep 19, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Sep 15, 2022

What this PR changes/adds

Avoid "severe" log on AzureVault when secret is not found.

Why it does that

To avoid misleading logs

Further notes

  • test-covered the resolveSecret method
  • remove useless CountDownLatch on AzureVaultExtensionTest

Linked Issue(s)

Closes #1962

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt added the enhancement New feature or request label Sep 15, 2022
@ndr-brt ndr-brt temporarily deployed to Azure-dev September 15, 2022 09:28 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #1963 (15e7226) into main (0e4b166) will increase coverage by 0.17%.
The diff coverage is 34.61%.

@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   62.80%   62.97%   +0.17%     
==========================================
  Files         782      782              
  Lines       16616    16643      +27     
  Branches     1080     1081       +1     
==========================================
+ Hits        10435    10481      +46     
+ Misses       5730     5712      -18     
+ Partials      451      450       -1     
Impacted Files Coverage Δ
...spaceconnector/core/security/azure/AzureVault.java 26.56% <34.61%> (+26.56%) ⬆️
...smos/policy/store/CosmosPolicyDefinitionStore.java 91.30% <0.00%> (-6.32%) ⬇️
...osmos/policy/store/CosmosPolicyStoreExtension.java 0.00% <0.00%> (ø)
...store/schema/postgres/PolicyDefinitionMapping.java 100.00% <0.00%> (ø)
...sfer/core/transfer/TransferProcessManagerImpl.java 88.43% <0.00%> (+2.44%) ⬆️
.../policy/store/schema/SqlPolicyStoreStatements.java 92.30% <0.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ndr-brt ndr-brt temporarily deployed to Azure-dev September 15, 2022 09:48 Inactive
@ndr-brt ndr-brt temporarily deployed to Azure-dev September 15, 2022 14:47 Inactive
@ndr-brt ndr-brt temporarily deployed to Azure-dev September 16, 2022 06:43 Inactive
@ndr-brt ndr-brt merged commit ec694a4 into eclipse-edc:main Sep 19, 2022
@ndr-brt ndr-brt deleted the feature/1962-avoid-log-azure-vault branch September 19, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid severe logging on AzureVault if secret is not found
4 participants