Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog types must be serialized as part of the catalog property #4586

Closed
jimmarino opened this issue Oct 28, 2024 · 0 comments · Fixed by #4588
Closed

Catalog types must be serialized as part of the catalog property #4586

jimmarino opened this issue Oct 28, 2024 · 0 comments · Fixed by #4588
Assignees
Labels
bug_report Suspected bugs, awaiting triage

Comments

@jimmarino
Copy link
Contributor

Bug Report

Describe the Bug

Currently, (sub)catalogs of type Catalog are serialized as part of the dataset property in a catalog. Per the DCAT 3 specification, this should be part of the catalog property.

This change needs to be made in the JsonObjectFromCatalogTransformer to filter on types:

        var datasets = catalog.getDatasets().stream()
                .map(offer -> context.transform(offer, JsonObject.class))
                .collect(toJsonArray());
@jimmarino jimmarino added bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification and removed triage all new issues awaiting classification labels Oct 28, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Oct 28, 2024
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug_report Suspected bugs, awaiting triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants