Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sub-catalogs serialization #4588

Merged

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

fixes sub-catalogs serialization

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4586

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood force-pushed the fix/4586_subcatalogs_serialization branch from 319cb42 to dc01dcd Compare October 28, 2024 14:30
@wolf4ood wolf4ood self-assigned this Oct 28, 2024
@wolf4ood wolf4ood added the bug Something isn't working label Oct 28, 2024
Copy link

github-actions bot commented Nov 5, 2024

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added stale Open for x days with no activity and removed stale Open for x days with no activity labels Nov 5, 2024
@wolf4ood wolf4ood force-pushed the fix/4586_subcatalogs_serialization branch from dc01dcd to 1c3d539 Compare November 11, 2024 13:57
@wolf4ood wolf4ood marked this pull request as ready for review November 11, 2024 14:54
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this will likely break the FC's catalog deserialization. probably makes sense to update FC right after.

@wolf4ood
Copy link
Contributor Author

Will merge it tomorrow then so I can quickly work on FCC

@wolf4ood wolf4ood added the breaking-change Will require manual intervention for version update label Nov 12, 2024
@wolf4ood wolf4ood merged commit fab363c into eclipse-edc:main Nov 12, 2024
24 checks passed
@wolf4ood wolf4ood deleted the fix/4586_subcatalogs_serialization branch November 12, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog types must be serialized as part of the catalog property
4 participants