Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataPlaneFramework: add Micrometer instrumentation #837

Closed
paullatzelsperger opened this issue Mar 7, 2022 · 6 comments
Closed

DataPlaneFramework: add Micrometer instrumentation #837

paullatzelsperger opened this issue Mar 7, 2022 · 6 comments
Assignees
@paullatzelsperger
Labels
core feature documentation Improvements or additions to documentation dpf Feature related to the Data Plane Framework enhancement New feature or request
Milestone
Backlog

Comments

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Mar 7, 2022 •
edited
Loading

For a holistic end-to-end picture we need to add OpenTelemetry and Micrometer instrumentation to it.
As those two topics are closely related they can be done in the same issue.
@paullatzelsperger paullatzelsperger added documentation Improvements or additions to documentation enhancement New feature or request core feature dpf Feature related to the Data Plane Framework labels Mar 7, 2022
@paullatzelsperger paullatzelsperger added this to the Milestone 3 milestone Mar 7, 2022
@paullatzelsperger paullatzelsperger self-assigned this Mar 7, 2022
@mspiekermann mspiekermann modified the milestones: Milestone 3, Milestone 4 Apr 8, 2022
@bscholtes1A
Copy link
Contributor

Hi @marcgs
is there something to be implemented on top of your PR #1162 for that issue to be closed?

@marcgs
Copy link
Contributor

marcgs commented May 2, 2022 •
edited
Loading

Hi @marcgs is there something to be implemented on top of your PR #1162 for that issue to be closed?

My PR took care of the distributed tracing part with Open Telemetry only. Metrics with Micrometer are mostly reused from what is already available from EDC since #637 . We could still add executor instrumentation for asynchronous processing in DataPlaneManagerImpl to see execution times for each loop if relevant (would require rework of the looping logic). WDYT @paullatzelsperger ?

@paullatzelsperger
Copy link
Member Author

I haven't looked at the code closely, but if we instrument it, we should instrument it everywhere.

@bscholtes1A
Copy link
Contributor

Hi @marcgs @paullatzelsperger
coming back to this one.

What is then still required to close this one? (as this is planned for milestone 4)
Only instrumentation of the parallel processing in DataPlaneManagerImpl? If yes I can take care of that

@paullatzelsperger
Copy link
Member Author

@bscholtes1A if you could do that, that would be great. the CSE crew is out this week.

@juliapampus juliapampus modified the milestones: Milestone 4, Milestone 5 Jun 1, 2022
@paullatzelsperger
Copy link
Member Author

@bscholtes1A any updates? is there more work necessary, or is it done?

@juliapampus juliapampus modified the milestones: Milestone 5, Backlog Jul 18, 2022
@juliapampus juliapampus reopened this Jul 18, 2022
@juliapampus juliapampus closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paullatzelsperger paullatzelsperger

Labels
core feature documentation Improvements or additions to documentation dpf Feature related to the Data Plane Framework enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@marcgs @paullatzelsperger @juliapampus @mspiekermann @bscholtes1A