-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observability: Trace context propagation within DPF #1162
Observability: Trace context propagation within DPF #1162
Conversation
3b0eaa3
to
4d64fc7
Compare
Hi @marcgs Is there any way to limit dependencies on external libraries to non-spi submodules? |
HI @bscholtes1A , thanks for your comment :-). All |
.../src/main/java/org/eclipse/dataspaceconnector/spi/types/domain/transfer/DataFlowRequest.java
Show resolved
Hide resolved
4d64fc7
to
bcb3863
Compare
ParallelSink) Co-authored-by: Alexandre Gattiker <[email protected]>
bcb3863
to
1f5782c
Compare
@bscholtes1A @jimmarino Could we merge this PR as it already has 2 approvals? |
What this PR changes/adds
Add trace context propagation at different points within DPF:
DataPlaneManagerImpl
: trace context is propagated to the corresponding async worker threads through the "DataFlowRequest" entities stored in the processing queue.ParallelSink
: trace context is propagated to the async workers that process parts. No entity is persisted in this case, the trace context is propagated in memory.Additionally
TracingIntegrationTest
was extended to verify traces propagation within DPF is working properly.Why it does that
In order to have traces spanning across asynchronous calls it is required to propagate the tracing context to worker threads. See resulting trace visualization in Jaeger:
Linked Issue(s)
Closes #936
Checklist
no-changelog
)