-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples: Use Datamanagment API to initiate file transfer #227
Samples: Use Datamanagment API to initiate file transfer #227
Conversation
This reverts commit f97672e.
1f0b083
to
61dcafb
Compare
Suggesting to add the changes in this commit: 8a1ac4b. This enhances the README with instructions how to perform file transfers and shows screenshots of the traces for contract negotiations and file transfers. Note: eclipse-edc#1162 is required for traces in DPF |
Codecov Report
@@ Coverage Diff @@
## feature/1120-update-samples-use-data-management-api #227 +/- ##
=========================================================================================
- Coverage 62.63% 62.63% -0.01%
- Complexity 2973 2984 +11
=========================================================================================
Files 694 695 +1
Lines 15420 15464 +44
Branches 1043 1048 +5
=========================================================================================
+ Hits 9659 9686 +27
- Misses 5332 5347 +15
- Partials 429 431 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comment
@marcgs As discussed picked up changes from commit 8a1ac4b into this PR. Please take a look. |
795289a
into
feature/1120-update-samples-use-data-management-api
* tmp * Revert "tmp" This reverts commit f97672e. * Updating Sample04 to use data management api for asset transfer * Update sample04.1 * Update sample04.3 * Remove duplicate * Update sample04.3 * Update sample04.3 * Update sample 4.3 * Update sample4.3 * Update sample Co-authored-by: Marc Gomez <[email protected]>
…pse-edc#1194) * tmp * Revert "tmp" This reverts commit f97672e. * Updating Sample04 to use data management api for asset transfer * Update sample04.1 * Update sample04.3 * Remove duplicate * Update sample04.3 * Update sample04.3 * Update sample 4.3 * Update sample4.3 * Update sample Co-authored-by: Marc Gomez <[email protected]> Co-authored-by: Marc Gomez <[email protected]>
What this PR changes/adds
Why it does that
To use DataManagement API.
Further notes
Follow PR of #221
Linked Issue(s)
Closes #228
Checklist
no-changelog
)