Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples: Use Datamanagment API to initiate file transfer #227

Conversation

cpeeyush
Copy link

@cpeeyush cpeeyush commented Apr 14, 2022

What this PR changes/adds

  • Updated samples to work with DataManagement API to initiate file transfer.
  • Removed existing custom implementation of ConsumerApiController.
  • Updated docs.

Why it does that

To use DataManagement API.

Further notes

Follow PR of #221

Linked Issue(s)

Closes #228

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@cpeeyush cpeeyush force-pushed the feature/1120/38-update-samples-use-data-management-api branch from 1f0b083 to 61dcafb Compare April 14, 2022 13:42
@cpeeyush cpeeyush changed the base branch from feature/1120/38-update-system-test-use-data-management-api to feature/1120-update-system-test-use-data-management-api April 14, 2022 13:42
@github-actions
Copy link

github-actions bot commented Apr 14, 2022

Unit Test Results

     355 files  ±0       355 suites  ±0   3m 54s ⏱️ -46s
11 950 tests ±0  11 936 ✔️ ±0  14 💤 ±0  0 ±0 
12 011 runs  ±0  11 997 ✔️ ±0  14 💤 ±0  0 ±0 

Results for commit b66ac8c. ± Comparison against base commit 6ca6ffe.

♻️ This comment has been updated with latest results.

@cpeeyush cpeeyush changed the base branch from feature/1120-update-system-test-use-data-management-api to feature/1120-update-samples-use-data-management-api April 14, 2022 14:01
@cpeeyush cpeeyush marked this pull request as ready for review April 14, 2022 15:44
@cpeeyush cpeeyush requested a review from algattik as a code owner April 14, 2022 15:44
@marcgs
Copy link

marcgs commented Apr 16, 2022

Suggesting to add the changes in this commit: 8a1ac4b. This enhances the README with instructions how to perform file transfers and shows screenshots of the traces for contract negotiations and file transfers.

Note: eclipse-edc#1162 is required for traces in DPF

@marcgs marcgs mentioned this pull request Apr 16, 2022
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #227 (8a1ac4b) into feature/1120-update-samples-use-data-management-api (6ca6ffe) will decrease coverage by 0.00%.
The diff coverage is 68.05%.

❗ Current head 8a1ac4b differs from pull request most recent head b66ac8c. Consider uploading reports for the commit b66ac8c to get more accurate results

@@                                    Coverage Diff                                    @@
##             feature/1120-update-samples-use-data-management-api     #227      +/-   ##
=========================================================================================
- Coverage                                                  62.63%   62.63%   -0.01%     
- Complexity                                                  2973     2984      +11     
=========================================================================================
  Files                                                        694      695       +1     
  Lines                                                      15420    15464      +44     
  Branches                                                    1043     1048       +5     
=========================================================================================
+ Hits                                                        9659     9686      +27     
- Misses                                                      5332     5347      +15     
- Partials                                                     429      431       +2     
Impacted Files Coverage Δ
...core/transfer/TransferProcessSendRetryManager.java 89.47% <ø> (ø)
...r/api/exception/mappers/EdcApiExceptionMapper.java 100.00% <ø> (ø)
...tamanagement/policy/service/PolicyServiceImpl.java 87.09% <ø> (ø)
...nnector/aws/dataplane/s3/DataPlaneS3Extension.java 100.00% <ø> (ø)
...ataspaceconnector/aws/dataplane/s3/S3DataSink.java 38.46% <ø> (ø)
...econnector/aws/dataplane/s3/S3DataSinkFactory.java 100.00% <ø> (ø)
...aspaceconnector/aws/dataplane/s3/S3DataSource.java 50.00% <ø> (ø)
...onnector/aws/dataplane/s3/S3DataSourceFactory.java 100.00% <ø> (ø)
...taplane/s3/validation/CompositeValidationRule.java 100.00% <ø> (ø)
...aplane/s3/validation/EmptyValueValidationRule.java 100.00% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca6ffe...b66ac8c. Read the comment docs.

@cpeeyush cpeeyush linked an issue Apr 19, 2022 that may be closed by this pull request
3 tasks
@zeier zeier requested a review from marcgs April 19, 2022 08:41
Copy link

@marcgs marcgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

@cpeeyush
Copy link
Author

Suggesting to add the changes in this commit: 8a1ac4b. This enhances the README with instructions how to perform file transfers and shows screenshots of the traces for contract negotiations and file transfers.

Note: eclipse-dataspaceconnector#1162 is required for traces in DPF

@marcgs As discussed picked up changes from commit 8a1ac4b into this PR. Please take a look.

@zeier zeier requested a review from ouphi April 21, 2022 08:36
@cpeeyush cpeeyush merged commit 795289a into feature/1120-update-samples-use-data-management-api Apr 21, 2022
cpeeyush added a commit that referenced this pull request Apr 21, 2022
* tmp

* Revert "tmp"

This reverts commit f97672e.

* Updating Sample04 to use data management api for asset transfer

* Update sample04.1

* Update sample04.3

* Remove duplicate

* Update sample04.3

* Update sample04.3

* Update sample 4.3

* Update sample4.3

* Update sample

Co-authored-by: Marc Gomez <[email protected]>
algattik pushed a commit that referenced this pull request Apr 24, 2022
…pse-edc#1194)

* tmp

* Revert "tmp"

This reverts commit f97672e.

* Updating Sample04 to use data management api for asset transfer

* Update sample04.1

* Update sample04.3

* Remove duplicate

* Update sample04.3

* Update sample04.3

* Update sample 4.3

* Update sample4.3

* Update sample

Co-authored-by: Marc Gomez <[email protected]>

Co-authored-by: Marc Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Tests: Update EDC System test to use DataManagement API for asset transfer
4 participants