Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: use @component test in sql tests #1143

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Apr 13, 2022

What this PR changes/adds

Adds the @ComponentTest annotation to all SQL-related tests.

Why it does that

Those tests are not unit tests (the use non-mocked collaborators such as H2) and therefore should only run when triggered explicitly to reduce test runtime on local machines.

Further notes

  • I also added a short test summary to the root buildfile, which produces output such as
    -----------------------------------------------------------------
    |  Results: SUCCESS (32 tests, 32 passed, 0 failed, 0 skipped)  |  
    -----------------------------------------------------------------
    

Linked Issue(s)

Closes #1132

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger changed the title Feature/1132 use @component test in sql tests Feature: use @component test in sql tests Apr 13, 2022
@paullatzelsperger
Copy link
Member Author

#1151 implements @marcgs's suggestion of moving the summary out to a plugin. whichever PR we merge first - the other must remove the code from the build file.

@paullatzelsperger paullatzelsperger force-pushed the feature/1132_use_@ComponentTest_in_sql_tests branch from 595f437 to 3f76378 Compare April 20, 2022 17:29
@bscholtes1A bscholtes1A merged commit a552ed0 into eclipse-edc:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: use @ComponentTest in all SQL-related tests
3 participants