core: replace policies with ids in ContractDefinition #1144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Replace the fields
accessPolicy
andcontractPolicy
withaccessPolicyId
andcontractPolicyId
onContractDefinition
, and injectPolicyStore
toContractDefinitionServiceImpl
,ContractValidationServiceImpl
andContractOfferServiceImpl
Why it does that
Because policies are stored separately from contract definitions and they can be referenced by their id
Further notes
NullAssetIndex
as its use was impossible to reach.data-loader-cli
needs further work but seemed too much for this PR. Since data-management api is in place is it still useful?Linked Issue(s)
Closes #1137
Part 3. of #828
Checklist
no-changelog
)