-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: adds signing config to gradle #1149
Build: adds signing config to gradle #1149
Conversation
b8f6a1f
to
1cdb9cd
Compare
edcDeveloperId=mspiekermann | ||
edcDeveloperName=Markus Spiekermann | ||
[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mspiekermann are you cool with adding you as "the man"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, if this is a mandatory field, I don't mind if you add my name and mail. Maybe it would be a good idea to name a second? Had a quick look on other projects and mostly two developers are mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to provide more than one developer
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
============================================
+ Coverage 62.63% 62.65% +0.01%
- Complexity 2973 2981 +8
============================================
Files 694 694
Lines 15420 15428 +8
Branches 1043 1048 +5
============================================
+ Hits 9658 9666 +8
+ Misses 5332 5331 -1
- Partials 430 431 +1
Continue to review full report at Codecov.
|
468e157
to
8bdc915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes
- files needing correction for doc generation have been addressed and match up with the records I have
- pulling branch and confirming that the execution runs as expected generating necessary artifacts
8bdc915
to
d6e0fa8
Compare
@jimmarino @juliapampus @MoritzKeppler @mspiekermann how do we proceed with this? should we merge it and try to get it to build on JIPP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed confirmation that all necessary artifacts are being signed with local build and against a Jenkins local instance. Per previous comments the rest of the files that needed to be modified (contained formatting errors) align with the list of those I found.
d6e0fa8
to
568ba11
Compare
What this PR changes/adds
Adds publication config, such as project name, description, etc. plus the OSSHR Maven repository as well as signing configs to the build file.
Why it does that
Required by OSSRH/MavenCentral
Todo
Further notes:
./gradlew publishToMavenLocal
now takes very long (>5min on an Intel i9), and it seems not to be multi-thread-able. It's probably the signing that actually takes so long.Linked Issue(s)
Closes #1147
Closes #1123
Checklist
no-changelog
)