Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: adds signing config to gradle #1149

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Apr 13, 2022

What this PR changes/adds

Adds publication config, such as project name, description, etc. plus the OSSHR Maven repository as well as signing configs to the build file.

Why it does that

Required by OSSRH/MavenCentral

Todo

  • Should the signing stuff get moved into its own plugin?

Further notes:

  • ./gradlew publishToMavenLocal now takes very long (>5min on an Intel i9), and it seems not to be multi-thread-able. It's probably the signing that actually takes so long.

Linked Issue(s)

Closes #1147
Closes #1123

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Comment on lines +36 to +39
edcDeveloperId=mspiekermann
edcDeveloperName=Markus Spiekermann
[email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mspiekermann are you cool with adding you as "the man"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, if this is a mandatory field, I don't mind if you add my name and mail. Maybe it would be a good idea to name a second? Had a quick look on other projects and mostly two developers are mentioned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to provide more than one developer

@codecov-commenter
Copy link

Codecov Report

Merging #1149 (468e157) into main (24956ec) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1149      +/-   ##
============================================
+ Coverage     62.63%   62.65%   +0.01%     
- Complexity     2973     2981       +8     
============================================
  Files           694      694              
  Lines         15420    15428       +8     
  Branches       1043     1048       +5     
============================================
+ Hits           9658     9666       +8     
+ Misses         5332     5331       -1     
- Partials        430      431       +1     
Impacted Files Coverage Δ
...taspaceconnector/core/base/policy/ScopeFilter.java 92.64% <ø> (ø)
...paceconnector/boot/system/runtime/BaseRuntime.java 0.00% <0.00%> (ø)
...sfer/core/transfer/TransferProcessManagerImpl.java 78.22% <ø> (ø)
...transform/IdsRepresentationToAssetTransformer.java 71.42% <ø> (ø)
...r/ids/transform/IdsResourceToAssetTransformer.java 66.66% <ø> (ø)
...ataspaceconnector/azure/cosmos/CosmosDocument.java 71.42% <ø> (ø)
...aceconnector/sql/lease/SqlLeaseContextBuilder.java 86.66% <ø> (ø)
...tor/spi/types/domain/transfer/TransferProcess.java 75.75% <0.00%> (ø)
...s/core/policy/CustomIdsConstraintDeserializer.java 96.66% <0.00%> (-3.34%) ⬇️
...aspaceconnector/ids/policy/IdsPolicyExtension.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24956ec...468e157. Read the comment docs.

Copy link
Contributor

@chrislomonico chrislomonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes

  • files needing correction for doc generation have been addressed and match up with the records I have
  • pulling branch and confirming that the execution runs as expected generating necessary artifacts

@paullatzelsperger paullatzelsperger force-pushed the chore/1147_signing_config branch from 8bdc915 to d6e0fa8 Compare April 28, 2022 09:52
@paullatzelsperger
Copy link
Member Author

@jimmarino @juliapampus @MoritzKeppler @mspiekermann how do we proceed with this? should we merge it and try to get it to build on JIPP?

Copy link
Contributor

@chrislomonico chrislomonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed confirmation that all necessary artifacts are being signed with local build and against a Jenkins local instance. Per previous comments the rest of the files that needed to be modified (contained formatting errors) align with the list of those I found.

@paullatzelsperger paullatzelsperger force-pushed the chore/1147_signing_config branch from d6e0fa8 to 568ba11 Compare May 12, 2022 09:14
@paullatzelsperger paullatzelsperger merged commit 282594f into eclipse-edc:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: add signing configuration to all artifacts Build: add Gradle task+plugin for signing
4 participants