Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent consumer DPF proxy to filter request arguments #1212

Conversation

bscholtes1A
Copy link
Contributor

@bscholtes1A bscholtes1A commented Apr 25, 2022

What this PR changes/adds

This PR adds the boolean flags for request properties (query params, request body...) to the http DataAddress generated to represent the provider DPF proxy. Without these flags, all the request arguments get filtered by the consumer DPF proxy before they reach the provider DPF.

Why it does that

Recover proper DPF proxy behavior.

Linked Issue(s)

Contributes to #1180. One end-to-end test should be added in system-tests:e2e-transfer-test in order to close the issue. This will be done in a separated PR, once #1199 is merged.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@bscholtes1A bscholtes1A added bug Something isn't working dpf Feature related to the Data Plane Framework no-changelog labels Apr 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1212 (e5022ac) into main (60da937) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1212      +/-   ##
============================================
+ Coverage     58.58%   58.64%   +0.05%     
- Complexity     2727     2731       +4     
============================================
  Files           697      698       +1     
  Lines         15436    15451      +15     
  Branches       1047     1049       +2     
============================================
+ Hits           9043     9061      +18     
+ Misses         5969     5967       -2     
+ Partials        424      423       -1     
Impacted Files Coverage Δ
...oxy/DataPlaneTransferConsumerProxyTransformer.java 95.83% <100.00%> (+0.83%) ⬆️
.../core/security/DefaultPrivateKeyParseFunction.java 86.66% <0.00%> (ø)
.../dataspaceconnector/boot/util/TopologicalSort.java 95.23% <0.00%> (+2.38%) ⬆️
...dataspaceconnector/core/CoreServicesExtension.java 96.77% <0.00%> (+5.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60da937...e5022ac. Read the comment docs.

@bscholtes1A bscholtes1A merged commit 2e21e5a into eclipse-edc:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dpf Feature related to the Data Plane Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants