Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace policy with policyId on ContractAgreement #1220

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Refactor: replace policy with policyId on ContractAgreement #1220

merged 2 commits into from
Apr 28, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 26, 2022

What this PR changes/adds

Replace Policy instance with policyIs on ContractAgreement

Why it does that

To avoid data duplication

Further notes

Linked Issue(s)

Closes #828

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt requested a review from juliapampus as a code owner April 26, 2022 14:10
@codecov-commenter
Copy link

Codecov Report

Merging #1220 (219aecb) into main (2e21e5a) will decrease coverage by 0.01%.
The diff coverage is 60.86%.

@@             Coverage Diff              @@
##               main    #1220      +/-   ##
============================================
- Coverage     58.63%   58.62%   -0.02%     
- Complexity     2731     2736       +5     
============================================
  Files           698      700       +2     
  Lines         15451    15502      +51     
  Branches       1049     1032      -17     
============================================
+ Hits           9060     9088      +28     
- Misses         5967     5997      +30     
+ Partials        424      417       -7     
Impacted Files Coverage Δ
...tcher/sender/MultipartContractAgreementSender.java 0.00% <0.00%> (ø)
...pi/multipart/handler/ContractAgreementHandler.java 0.00% <0.00%> (ø)
.../transform/ContractAgreementTransformerOutput.java 0.00% <0.00%> (ø)
...or/ids/transform/IdsTransformServiceExtension.java 80.00% <ø> (-5.72%) ⬇️
.../contractnegotiation/store/PostgresStatements.java 3.12% <0.00%> (-0.11%) ⬇️
...negotiation/store/SqlContractNegotiationStore.java 4.44% <0.00%> (+0.04%) ⬆️
...s/domain/contract/agreement/ContractAgreement.java 0.00% <0.00%> (ø)
...n/contract/agreement/ContractAgreementRequest.java 0.00% <0.00%> (ø)
...ementRequestToIdsContractAgreementTransformer.java 75.51% <75.51%> (ø)
...ceconnector/contract/ContractServiceExtension.java 95.08% <100.00%> (+0.16%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e21e5a...219aecb. Read the comment docs.

@ndr-brt ndr-brt requested a review from ronjaquensel April 27, 2022 10:03
@bscholtes1A bscholtes1A merged commit fab107c into eclipse-edc:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor structure of business objects
5 participants