-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: update documentation #1224
samples: update documentation #1224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to either add a few sentences about the token-based API authentication or remove it from the build file. Currently it's there, but is never mentioned in the README
. Therefore, when someone runs this sample and tries to call the health endpoint again to see the new log prefix, they'll get a 403.
@ronjaquensel yeah, you're right, removed it from the build file and from the readme |
@ndr-brt The other samples that build on this one also use token based. Here you should possibly also take this out. |
@florianrusch-zf I don't know, in sample-04.0 the "auth key" stuff is explained in the README, maybe removing it will remove value from the sample? |
@ndr-brt Ahhhh sorry, of course! Then everything is fine for me so far. Thank you! :-) |
What this PR changes/adds
Update sample-03 documentation
Why it does that
It was out of date.
Further notes
Linked Issue(s)
Closes #1218
Checklist
no-changelog
)