Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: exclude sample and system-tests modules from module name check also if edc is loaded as submodule #1234

Merged
merged 1 commit into from
Apr 29, 2022
Merged

bugfix: exclude sample and system-tests modules from module name check also if edc is loaded as submodule #1234

merged 1 commit into from
Apr 29, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 29, 2022

What this PR changes/adds

Changes how the ModuleNamePlugin excludes samples ans system-tests

Why it does that

To permit EDC to be loaded as submodule

Further notes

Linked Issue(s)

Closes #1232

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

Codecov Report

Merging #1234 (0dcb94e) into main (9d0ba10) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1234   +/-   ##
=========================================
  Coverage     59.14%   59.14%           
  Complexity     2824     2824           
=========================================
  Files           715      715           
  Lines         15691    15691           
  Branches       1036     1036           
=========================================
  Hits           9281     9281           
  Misses         5990     5990           
  Partials        420      420           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0ba10...0dcb94e. Read the comment docs.

@ndr-brt ndr-brt requested review from bscholtes1A and marcgs April 29, 2022 07:54
@bscholtes1A bscholtes1A merged commit cfd66dc into eclipse-edc:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNamesPlugin falsely throws error when Implementing EDC as submodule
4 participants