Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-plane: enable contract validation rule #1239

Merged
merged 2 commits into from
Apr 29, 2022
Merged

data-plane: enable contract validation rule #1239

merged 2 commits into from
Apr 29, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 29, 2022

What this PR changes/adds

As #1227 fixed date serdes, this PR enable ContractValidationRule.

Why it does that

To verify that the contract is still valid before transferring data.

Further notes

Linked Issue(s)

Closes #1127

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt requested a review from bscholtes1A as a code owner April 29, 2022 12:35
@ndr-brt ndr-brt requested a review from ronjaquensel April 29, 2022 12:35
@codecov-commenter
Copy link

Codecov Report

Merging #1239 (a989be4) into main (39aa066) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1239      +/-   ##
============================================
+ Coverage     59.19%   59.26%   +0.07%     
- Complexity     2830     2835       +5     
============================================
  Files           719      719              
  Lines         15705    15707       +2     
  Branches       1036     1037       +1     
============================================
+ Hits           9296     9309      +13     
+ Misses         5989     5978      -11     
  Partials        420      420              
Impacted Files Coverage Δ
...taplane/sync/api/rules/ContractValidationRule.java 86.66% <100.00%> (+86.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39aa066...a989be4. Read the comment docs.

@bscholtes1A bscholtes1A merged commit 1a552e9 into eclipse-edc:main Apr 29, 2022
@ndr-brt ndr-brt deleted the feature/1127-contract-end-date-validation branch May 3, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract Negotiation: end date validation
4 participants