Feature: FCC node directory is queried on every plan execution #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bscholtes1A
approved these changes
May 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
============================================
- Coverage 59.37% 59.36% -0.02%
+ Complexity 2837 2835 -2
============================================
Files 712 712
Lines 15689 15689
Branches 1037 1037
============================================
- Hits 9315 9313 -2
- Misses 5954 5956 +2
Partials 420 420
Continue to review full report at Codecov.
|
algattik
reviewed
May 3, 2022
.../main/java/org/eclipse/dataspaceconnector/catalog/cache/management/PartitionManagerImpl.java
Outdated
Show resolved
Hide resolved
algattik
approved these changes
May 3, 2022
…clipse/dataspaceconnector/catalog/cache/management/PartitionManagerImpl.java Co-authored-by: Alexandre Gattiker <[email protected]>
algattik
added a commit
to agera-edc/DataSpaceConnector
that referenced
this pull request
May 3, 2022
…se-edc#1243) * node directory is queried on every plan execution * checkstyle * Update extensions/catalog/federated-catalog-cache/src/main/java/org/eclipse/dataspaceconnector/catalog/cache/management/PartitionManagerImpl.java Co-authored-by: Alexandre Gattiker <[email protected]> Co-authored-by: Alexandre Gattiker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
On every crawler run that the
PartitionManagerImplschedules, theFederatedCacheNodeDirectoryis queried to get up-to-date information about "who is in the dataspace".Note the periodic scheduling is implemented in the
ExecutionPlan, or more specifically theRecurringExecutionPlan. This is because crawlers themselves are not scheduled in any form, they merely activate when a newWorkItemarrives in their queue.Why it does that
To be able to react to changes in the node directory
Further notes
Linked Issue(s)
Closes #1230
Checklist
no-changelog)