Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD: Include component tests coverage in codecov code coverage report. #1246

Conversation

ouphi
Copy link
Contributor

@ouphi ouphi commented May 2, 2022

What this PR changes/adds

Include component tests coverage in codecov coverage report.

Why it does that

It makes more sense that component tests coverage is included in coverage report as they are unit tests.

Linked Issue(s)

Closes #1217

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

ouphi added 3 commits May 2, 2022 14:53
…#245)

Include component tests coverage in codecov code coverage report.
…ub.com:agera-edc/DataSpaceConnector into feature/1217-include-component-tests-in-report
@ouphi ouphi marked this pull request as ready for review May 2, 2022 13:13
@codecov-commenter
Copy link

Codecov Report

Merging #1246 (6b66647) into main (0da15e1) will increase coverage by 7.82%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1246      +/-   ##
============================================
+ Coverage     59.37%   67.19%   +7.82%     
============================================
  Files           712      712              
  Lines         15689    15689              
  Branches       1037     1037              
============================================
+ Hits           9315    10542    +1227     
+ Misses         5954     4667    -1287     
- Partials        420      480      +60     
Impacted Files Coverage Δ
...iation/ProviderContractNegotiationManagerImpl.java 90.86% <0.00%> (+0.53%) ⬆️
...ids/api/multipart/handler/ResponseMessageUtil.java 70.73% <0.00%> (+2.43%) ⬆️
.../api/multipart/handler/ArtifactRequestHandler.java 66.21% <0.00%> (+2.70%) ⬆️
...nector/sql/asset/index/SqlConditionExpression.java 100.00% <0.00%> (+4.00%) ⬆️
...r/MultipartEndpointDataReferenceRequestSender.java 95.00% <0.00%> (+5.00%) ⬆️
...nder/MultipartCatalogDescriptionRequestSender.java 6.81% <0.00%> (+6.81%) ⬆️
...or/ids/api/multipart/message/MultipartRequest.java 93.75% <0.00%> (+12.50%) ⬆️
.../ids/api/multipart/handler/DescriptionHandler.java 65.95% <0.00%> (+19.14%) ⬆️
...patcher/sender/MultipartArtifactRequestSender.java 77.35% <0.00%> (+22.64%) ⬆️
...ispatcher/IdsMultipartRemoteMessageDispatcher.java 50.00% <0.00%> (+50.00%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da15e1...6b66647. Read the comment docs.

@ouphi ouphi requested a review from paullatzelsperger May 2, 2022 15:55
@jimmarino
Copy link
Contributor

@ndr-brt Do you have access rights to merge this?

@ndr-brt ndr-brt merged commit 1cbce7d into eclipse-edc:main May 4, 2022
@ndr-brt
Copy link
Member

ndr-brt commented May 4, 2022

@jimmarino , yes I have them, I was just hesitating cause it was my first merge on this project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include component tests in Codecov report
5 participants